Embedded_Projects/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

virtio: fix get_config / set_config for legacy VirtIO targets

Browse Source 
The functions virtio_pci_get_config() and virtio_pci_set_config() don't
take the offset into account when reading the config space. For example
this manifests when U-Boot tries to read the MAC address of the VirtIO
networking device. It reads 6 equa bytes instead of the proper addess.

Fix those functions by taking the offset in the config space into
account.

Fixes: 4135e10732 ("virtio: Add virtio over pci transport driver")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
This commit is contained in:
Dmitry Baryshkov 2024-02-12 09:37:08 +02:00 committed by Tom Rini
parent 96ca3d362d
commit 3098115155
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/virtio/virtio_pci_legacy.c
View File

@ -107,7 +107,7 @@ static int virtio_pci_get_config(struct udevice *udev, unsigned int offset,
int i;
for (i = 0; i < len; i++)
ptr[i] = ioread8(ioaddr + i);
ptr[i] = ioread8(ioaddr + offset + i);
return 0;
}
@ -121,7 +121,7 @@ static int virtio_pci_set_config(struct udevice *udev, unsigned int offset,
int i;
for (i = 0; i < len; i++)
iowrite8(ptr[i], ioaddr + i);
iowrite8(ptr[i], ioaddr + offset + i);
return 0;
}