imi415
/
openocd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

helper/command: fix echo return values 

the echo command is managed through command handler and not jim_handler
to be consistent rename the handler from jim_echo to handle_echo
and update the return values

Fixes: 4747af362d (JIM: document "echo" command)
Change-Id: I5ae87ea802d8430b573fb83daa6b35490b5d5775
Signed-off-by: Tarek BOCHKATI <tarek.bouchkati@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/6549
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
This commit is contained in:
Tarek BOCHKATI 2021-08-11 01:14:21 +01:00 committed by Antonio Borneo
parent 1efd12a6de
commit 050fcb1760
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/helper/command.c
View File

@ -718,16 +718,18 @@ static int jim_find(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
return JIM_OK;
}
COMMAND_HANDLER(jim_echo)
COMMAND_HANDLER(handle_echo)
{
if (CMD_ARGC == 2 && !strcmp(CMD_ARGV[0], "-n")) {
LOG_USER_N("%s", CMD_ARGV[1]);
return JIM_OK;
return ERROR_OK;
}
if (CMD_ARGC != 1)
return JIM_ERR;
return ERROR_FAIL;
LOG_USER("%s", CMD_ARGV[0]);
return JIM_OK;
return ERROR_OK;
}
/* Capture progress output and return as tcl return value. If the
@ -1219,7 +1221,7 @@ static const struct command_registration command_builtin_handlers[] = {
},
{
.name = "echo",
.handler = jim_echo,
.handler = handle_echo,
.mode = COMMAND_ANY,
.help = "Logs a message at \"user\" priority. "
"Option \"-n\" suppresses trailing newline",