From 95135b39ccc3d8cec79053a71d0289e7fdeeafe9 Mon Sep 17 00:00:00 2001 From: Antonio Borneo Date: Wed, 1 Jun 2022 19:21:44 +0200 Subject: [PATCH] arm_adi_v5: fix scan-build warning [3/3] While scan-build complains that dap_p or ap_num_p could be NULL, the current code never passes NULL pointers. Add an assert() to silent scan-build and prevent any further use of the function with incorrect parameters. Change-Id: I656810dddcea61e85d85b13efb114f7607ef837c Signed-off-by: Antonio Borneo Reviewed-on: https://review.openocd.org/c/openocd/+/7012 Tested-by: jenkins Reviewed-by: Tomas Vanek --- src/target/arm_adi_v5.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/target/arm_adi_v5.c b/src/target/arm_adi_v5.c index 0b11e815d..52b12cb93 100644 --- a/src/target/arm_adi_v5.c +++ b/src/target/arm_adi_v5.c @@ -1938,6 +1938,8 @@ static const struct jim_nvp nvp_config_opts[] = { static int adiv5_jim_spot_configure(struct jim_getopt_info *goi, struct adiv5_dap **dap_p, int *ap_num_p, uint32_t *base_p) { + assert(dap_p && ap_num_p); + if (!goi->argc) return JIM_OK;