From d1b882f2c014258be5397067e45848fa5465b78b Mon Sep 17 00:00:00 2001 From: Tarek BOCHKATI Date: Sat, 28 May 2022 18:45:35 +0100 Subject: [PATCH] telnet_server: fix scan-build warning fix "Declared variable-length array (VLA) has zero size" warning raised in .../src/server/telnet_server.c:633:2: Change-Id: Icff5228b02790c472b212a86a3849b1a3df98fdb Signed-off-by: Tarek BOCHKATI Reviewed-on: https://review.openocd.org/c/openocd/+/6565 Tested-by: jenkins Reviewed-by: Antonio Borneo --- src/server/telnet_server.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/server/telnet_server.c b/src/server/telnet_server.c index 4fc71f384..8e796264c 100644 --- a/src/server/telnet_server.c +++ b/src/server/telnet_server.c @@ -615,7 +615,11 @@ static void telnet_auto_complete(struct connection *connection) while ((usr_cmd_pos < t_con->line_cursor) && isspace(t_con->line[usr_cmd_pos])) usr_cmd_pos++; - /* user command length */ + /* check user command length */ + if (t_con->line_cursor < usr_cmd_pos) { + telnet_bell(connection); + return; + } size_t usr_cmd_len = t_con->line_cursor - usr_cmd_pos; /* optimize multiple spaces in the user command,