imi415/openocd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
355f4cadbb
openocd/src/helper
History
Paul Fertser 355f4cadbb Use (uint8_t *) for buf_(set|get)_u(32|64) instead of (void *) 
This helps to uncover incorrect usage when a pointer to uint32_t is
passed to those functions which leads to subtle bugs on BE systems.

The reason is that it's normally assumed that any uint32_t variable
holds its value in host byte order, but using but_set_u32 on it
silently does implicit pointer conversion to (void *) and the
assumption ends up broken without any indication.

Change-Id: I48ffd190583d8aa32ec1fef8f1cdc0b4184e4546
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Reviewed-on: http://openocd.zylin.com/2467
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
2015-01-30 08:56:54 +00:00
..
bin2char.sh Fix some problems with the bin2char utility 2014-08-02 09:01:32 +00:00
binarybuffer.c helper: constify log_strings 2014-10-06 11:57:44 +00:00
binarybuffer.h Use (uint8_t *) for buf_(set|get)_u(32|64) instead of (void *) 2015-01-30 08:56:54 +00:00
command.c command: Fix confusing syntax error message 2014-09-22 19:40:38 +00:00
command.h Update to the current Jim Tcl 2014-05-09 20:12:17 +00:00
configuration.c Remove unnecessary casts 2013-10-31 20:43:27 +00:00
configuration.h update files to correct FSF address 2013-06-05 19:52:42 +00:00
fileio.c Clean up const usage to avoid excessive casting 2013-10-31 20:42:34 +00:00
fileio.h update files to correct FSF address 2013-06-05 19:52:42 +00:00
ioutil_stubs.c update files to correct FSF address 2013-06-05 19:52:42 +00:00
ioutil.c ioutil: Remove unnecessary casts and fix const-discarding 2013-10-31 20:45:34 +00:00
ioutil.h update files to correct FSF address 2013-06-05 19:52:42 +00:00
jim-nvp.c build: cleanup src/helper directory 2012-02-06 10:49:52 +00:00
jim-nvp.h build: cleanup src/helper directory 2012-02-06 10:49:52 +00:00
list.h Add a bit-level transfer queue 2012-07-06 14:58:25 +00:00
log.c helper: constify log_strings 2014-10-06 11:57:44 +00:00
log.h stlink_usb: Fix swallowed error on read/write operations, add retries on SWD WAIT, clean up error debug output. 2014-08-11 22:34:52 +00:00
Makefile.am Provide od+sed replacement for the bin2char helper 2014-08-02 09:00:28 +00:00
options.c Removed limit on lenght of command line options. 2014-08-12 21:04:27 +00:00
replacements.c Don't cast return value of [cm]alloc 2014-03-30 03:53:45 +00:00
replacements.h libusb1_common, ftdi: clarify libusb_open error message 2013-06-12 14:40:16 +00:00
startup.tcl command: Fix confusing syntax error message 2014-09-22 19:40:38 +00:00
system.h update files to correct FSF address 2013-06-05 19:52:42 +00:00
time_support_common.c update files to correct FSF address 2013-06-05 19:52:42 +00:00
time_support.c update files to correct FSF address 2013-06-05 19:52:42 +00:00
time_support.h update files to correct FSF address 2013-06-05 19:52:42 +00:00
types.h swd: Improve parity calculation and move it to types.h 2014-06-28 09:27:19 +00:00
util.c update files to correct FSF address 2013-06-05 19:52:42 +00:00
util.h update files to correct FSF address 2013-06-05 19:52:42 +00:00