openocd/src/server
Antonio Borneo bc50b8f1b2 gdb_server: fix double free
Commit 6541233aa7 ("Combine register lists of smp targets.")
unconditionally assigns the output pointers of the function
smp_reg_list_noread(), even if the function fails and returns
error.
This causes a double free from the caller, that has assigned NULL
to the pointers to simplify the error handling.

Use local variables in smp_reg_list_noread() and assign the output
pointers only on success.

Change-Id: Ic0fd2f26520566cf322f0190780e15637c01cfae
Fixes: 6541233aa7 ("Combine register lists of smp targets.")
Reported-by: Michele Bisogno <michele.bisogno.ct@renesas.com>
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/6852
Tested-by: jenkins
Reviewed-by: Michele Bisogno <michele.bisogno.ct@renesas.com>
Reviewed-by: Tim Newsome <tim@sifive.com>
2022-02-26 15:37:19 +00:00
..
gdb_server.c gdb_server: fix double free 2022-02-26 15:37:19 +00:00
gdb_server.h server: free strduped port numbers 2018-03-15 17:08:53 +00:00
ipdbg.c Add IPDBG JtagHost functionality to OpenOCD 2021-05-08 09:51:04 +01:00
ipdbg.h Add IPDBG JtagHost functionality to OpenOCD 2021-05-08 09:51:04 +01:00
Makefile.am server: remove remaining crust from dropped eCos code 2022-02-14 15:13:34 +00:00
rtt_server.c server: revert commit 7e6556b3ca 2021-03-10 21:34:13 +00:00
rtt_server.h Add initial RTT support 2020-12-02 23:15:52 +00:00
server.c server: remove remaining crust from dropped eCos code 2022-02-14 15:13:34 +00:00
server.h server: remove remaining crust from dropped eCos code 2022-02-14 15:13:34 +00:00
startup.tcl telnet/auto-complete: hide deprecated and internal commands 2021-05-08 09:48:15 +01:00
tcl_server.c openocd: remove NULL comparisons with checkpatch [1/2] 2021-07-24 10:38:00 +01:00
tcl_server.h server: free strduped port numbers 2018-03-15 17:08:53 +00:00
telnet_server.c server/telnet: add variables auto-completion 2021-08-31 04:13:01 +00:00
telnet_server.h server: free strduped port numbers 2018-03-15 17:08:53 +00:00