imi415
/
openocd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

checkpatch: disable extern and switch indent checks 

We allow extern's in c files so disable checkpatch checks.

Change-Id: Ia649585cd70ec45289c4edaf26c1fd773a140db4
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/284
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
This commit is contained in:
Spencer Oliver 2011-12-16 10:04:43 +00:00
parent 164450a015
commit 09571d62bc
1 changed files with 48 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
tools/scripts/checkpatch.pl
View File

@ -1823,26 +1823,26 @@ sub process {
# Check for switch () and associated case and default # Check for switch () and associated case and default
# statements should be at the same indent. # statements should be at the same indent.
if ($line=~/\bswitch\s*\(.*\)/) { # if ($line=~/\bswitch\s*\(.*\)/) {
my $err = ''; # my $err = '';
my $sep = ''; # my $sep = '';
my @ctx = ctx_block_outer($linenr, $realcnt); # my @ctx = ctx_block_outer($linenr, $realcnt);
shift(@ctx); # shift(@ctx);
for my $ctx (@ctx) { # for my $ctx (@ctx) {
my ($clen, $cindent) = line_stats($ctx); # my ($clen, $cindent) = line_stats($ctx);
if ($ctx =~ /^\+\s*(case\s+|default:)/ && # if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
$indent != $cindent) { # $indent != $cindent) {
$err .= "$sep$ctx\n"; # $err .= "$sep$ctx\n";
$sep = ''; # $sep = '';
} else { # } else {
$sep = "[...]\n"; # $sep = "[...]\n";
} # }
} # }
if ($err ne '') { # if ($err ne '') {
ERROR("SWITCH_CASE_INDENT_LEVEL", # ERROR("SWITCH_CASE_INDENT_LEVEL",
"switch and case should be at the same indent\n$hereline$err"); # "switch and case should be at the same indent\n$hereline$err");
} # }
} # }
# if/while/etc brace do not go on next line, unless defining a do while loop, # if/while/etc brace do not go on next line, unless defining a do while loop,
# or if that brace on the next line is for something else # or if that brace on the next line is for something else
@ -3088,34 +3088,34 @@ sub process {
} }
# check for new externs in .c files. # check for new externs in .c files.
if ($realfile =~ /\.c$/ && defined $stat && # if ($realfile =~ /\.c$/ && defined $stat &&
$stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s) # $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
{ # {
my $function_name = $1; # my $function_name = $1;
my $paren_space = $2; # my $paren_space = $2;
#
my $s = $stat; # my $s = $stat;
if (defined $cond) { # if (defined $cond) {
substr($s, 0, length($cond), ''); # substr($s, 0, length($cond), '');
} # }
if ($s =~ /^\s*;/ && # if ($s =~ /^\s*;/ &&
$function_name ne 'uninitialized_var') # $function_name ne 'uninitialized_var')
{ # {
WARN("AVOID_EXTERNS", # WARN("AVOID_EXTERNS",
"externs should be avoided in .c files\n" . $herecurr); # "externs should be avoided in .c files\n" . $herecurr);
} # }
#
if ($paren_space =~ /\n/) { # if ($paren_space =~ /\n/) {
WARN("FUNCTION_ARGUMENTS", # WARN("FUNCTION_ARGUMENTS",
"arguments for function declarations should follow identifier\n" . $herecurr); # "arguments for function declarations should follow identifier\n" . $herecurr);
} # }
#
} elsif ($realfile =~ /\.c$/ && defined $stat && # } elsif ($realfile =~ /\.c$/ && defined $stat &&
$stat =~ /^.\s*extern\s+/) # $stat =~ /^.\s*extern\s+/)
{ # {
WARN("AVOID_EXTERNS", # WARN("AVOID_EXTERNS",
"externs should be avoided in .c files\n" . $herecurr); # "externs should be avoided in .c files\n" . $herecurr);
} # }
# checks for new __setup's # checks for new __setup's
if ($rawline =~ /\b__setup\("([^"]*)"/) { if ($rawline =~ /\b__setup\("([^"]*)"/) {